Future proof adapters #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Mar 12, 2021
benmccann
reviewed
Mar 12, 2021
antony
reviewed
Mar 12, 2021
benmccann
reviewed
Mar 12, 2021
|
I made the last remaining |
benmccann
approved these changes
Mar 12, 2021
|
Probably need to update some of the examples and docs? |
|
Will be doing a sweep of the docs soon anyway (tonight, if possible). The examples were already updated, I think the tests just failed because they fail sometimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This future-proofs the adapter API in such a way that we can add new stuff (like platform-specific deployment logic, or metadata that instructs Vite to output CJS per #503) in a non-breaking way. It also makes #439 possible, if we can figure out what we want to do about the ESM headaches