Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace demo uuid dep with native method #4930

Closed
wants to merge 1 commit into from

Conversation

vhscom
Copy link

@vhscom vhscom commented May 15, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Backing issue: #4929

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Ran pnpm lint and pnpm check on create-svelte package. Script test does not exist there. Tested app locally by deleting userid cookie then reloading the page and verifying the cookie was recreated with a new random UUID. I did run the test target for kit but it failed after 374 passed tests with an unrelated error.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2022

🦋 Changeset detected

Latest commit: 9be95c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vhscom
Copy link
Author

vhscom commented May 16, 2022

Closing this pull as it won't deploy as-is to Cloudflare Pages using the Cloudflare adapter. Although Cloudflare Workers support crypto.randomUUID() the Pages build throws a ReferenceError due to the crypto import which is required within SvelteKit hooks file currently as the SvelteKit build occurs in a Node context.

@vhscom vhscom closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant