-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] bump eslint
from version 7 to 8
#4553
Conversation
🦋 Changeset detectedLatest commit: 2bd4f9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think we should first release a new major for |
That sounds fine to me. Is there any benefit to dropping Node 12 while we're at it, because it's EOL at the end of the month anyway? |
eslint
from version 7 to 8eslint
from version 7 to 8
The eslint plugin tests currently use an internal eslint class. eslint 8 adds an If that doesn't work we can see if we can hack around that by doing something like |
When a user creates a SvelteKit app with
eslint
support usingcreate-svelte
, it ships the lasteslint
release under major version 7. With this pull request,create-svelte
will now ship the latesteslint
release (for now).I'm worried that
eslint-plugin-svelte3
doesn't supporteslint@^8.0.0
, from this discussion.eslint-plugin-svelte3
's peerDependencies listseslint@>=6.0.0
since June 22, 2019, around wheneslint@6.0.1
was released.Related: #3261
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0