-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] use in memory object instead of Cloudflare KV API for demo app #4266
Conversation
🦋 Changeset detectedLatest commit: b909690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cd2377e
to
a3784ff
Compare
1cb6099
to
5c56cab
Compare
@baseballyama I thought using a Map would be more semantically correct, and abstracting the db operations would help with readability, so I've made a PR over at your branch baseballyama#6 |
The abstractions should make it easier to add some persistence as well if needed. |
Abstract over db operations
5d0dc12
to
7e6d9eb
Compare
7e6d9eb
to
b909690
Compare
I don't think there is consensus on this PR yet, but I have modified it so that we can try both in-memory objects and Cloudflare KV API. This is a just proposal, so please close it if it is not in line with the core team's decision. |
fix: #4264
I am accessing the Demo app from Tokyo but the response is not good.
I considered using indexedDB or Session Storage but did not adopt them because it is important that this process be performed on the back end.
And the process should not be complex to avoid making noise, so I finally opted for a simple in-memory object.
Any opinions for a better demo app?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0