Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] add @sveltejs/adapter-static to site package #4245

Merged
merged 2 commits into from
Mar 6, 2022
Merged

[chore] add @sveltejs/adapter-static to site package #4245

merged 2 commits into from
Mar 6, 2022

Conversation

baseballyama
Copy link
Member

Now deploy process seems failed. (e.g. https://app.netlify.com/sites/kit-demo/deploys/622468f183e8a9000860529a#L1048)
This PR fixes this issue.

Please see the below comments for more details.

#4244 (comment)
#4244 (comment)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@baseballyama
add @sveltejs/adapter-static.
7eb9e91 
sveltejs#4011 added @sveltejs/adapter-static .
But sveltejs#4239 removed it.
Then deploy process is failed. (Please see sveltejs#4244 (comment) for more details)
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: a720fcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

PH4NTOMiki
PH4NTOMiki reviewed Mar 6, 2022
View reviewed changes
sites/kit.svelte.dev/package.json Outdated
@@ -9,6 +9,7 @@
},
"devDependencies": {
"@sveltejs/adapter-auto": "workspace:*",
"@sveltejs/adapter-static": "workspace:^1.0.0-next.29",
Copy link
Contributor

@PH4NTOMiki PH4NTOMiki Mar 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@sveltejs/adapter-static": "workspace:^1.0.0-next.29",
"@sveltejs/adapter-static": "workspace:*",

I think this should be workspace:* like others are

Copy link
Member Author

@baseballyama baseballyama Mar 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply rollback to previous commit.
https://github.com/sveltejs/kit/blame/cdc32a9f4f17d69be6ca1cae58bf3961155545a2/sites/kit.svelte.dev/package.json

But workspace:* is better I think too.

PH4NTOMiki
PH4NTOMiki reviewed Mar 6, 2022
View reviewed changes
pnpm-lock.yaml Outdated
@@ -391,6 +391,7 @@ importers:
sites/kit.svelte.dev:
specifiers:
'@sveltejs/adapter-auto': workspace:*
'@sveltejs/adapter-static': workspace:^1.0.0-next.29
Copy link
Contributor

@PH4NTOMiki PH4NTOMiki Mar 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@sveltejs/adapter-static': workspace:^1.0.0-next.29
'@sveltejs/adapter-static': workspace:*

I think this should be workspace:* like others are

@Rich-Harris Rich-Harris merged commit 610684e into sveltejs:master Mar 6, 2022
@Rich-Harris
Copy link
Member

thanks!

@baseballyama baseballyama mentioned this pull request Mar 7, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PH4NTOMiki PH4NTOMiki PH4NTOMiki left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baseballyama @Rich-Harris @PH4NTOMiki