Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Ignore click event if href is mailto link #4072

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

baseballyama
Copy link
Member

fix: #4045

I didn't know how to test this, so I didn't implement a test. Instead, I put a comment in the code.
If you have any ideas for the test, please let me know!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2022

🦋 Changeset detected

Latest commit: 75b48f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Should we check for other custom URL schemes here as well? Is there a similar problem with, say, tel: links? Can we do this without hard coding specific schemes? It seems like any URL beginning with foo: should not be handled by the router and should be left to the browser.

@baseballyama
Copy link
Member Author

baseballyama commented Feb 23, 2022

@Conduitry

Ahh, this is really good point.

I think we can divert URL object.
Such mailto: or tel: doesn't have origin, so we can easily judge it by url.origin.

if (!is_svg_a_element && url.origin === 'null') return;

What do you think about it?

P.S: This might be helpful.
https://datatracker.ietf.org/doc/html/rfc3986#section-1.1.2

@Rich-Harris
Copy link
Member

yeah, that looks like a good solution to me. thanks!

@Rich-Harris Rich-Harris merged commit 266a460 into sveltejs:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailto: links open twice
3 participants