Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] render code blocks in sidebar nav #4000

Closed
wants to merge 1 commit into from
Closed

[docs] render code blocks in sidebar nav #4000

wants to merge 1 commit into from

Conversation

malinowskip
Copy link
Contributor

@malinowskip malinowskip commented Feb 18, 2022

Possible solution to #3987

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2022

⚠️ No Changeset found

Latest commit: 8e31559

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bluwy
Copy link
Member

bluwy commented Feb 19, 2022

Looks like this makes it stand out in the sidebar

image

Even if we can dim down the styles, I wonder if it would be better to avoid code blocks / backticks altogether so the font looks more consistent (#3990)

@bluwy bluwy added the documentation Improvements or additions to documentation label Feb 19, 2022
@bluwy bluwy linked an issue Feb 19, 2022 that may be closed by this pull request
@Rich-Harris
Copy link
Member

thanks, this was fixed separately in #4011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Inline code blocks are not rendered properly in the sidebar
3 participants