Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Server-side fetch request should have headers (#696) #2861

Closed
wants to merge 5 commits into from
Closed

[fix] Server-side fetch request should have headers (#696) #2861

wants to merge 5 commits into from

Conversation

aolose
Copy link
Contributor

@aolose aolose commented Nov 22, 2021

Server-side fetch in load function will include original request headers.

I'm only test it in the Page file , if server-side fetch not in load , headers will lost :( ,

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0927c32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann
benmccann reviewed Nov 22, 2021
View reviewed changes
packages/kit/src/runtime/server/page/load_node.js
@@ -101,6 +101,12 @@ export async function load_node({
};
}

//merge headers from request
Copy link
Member

@benmccann benmccann Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually put a space after //

Suggested change
//merge headers from request
// merge headers from request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces between words too, we should have one space only.

@benmccann
Copy link
Member

@aolose this PR would need to be rebased and my comment would need to be addressed

@aolose
Copy link
Contributor Author

aolose commented Jan 30, 2022 •
edited
Loading

I deleted the repo I forked earlier, so I fork it again.
The new pr is here: #3631.

@aolose this PR would need to be rebased and my comment would need to be addressed

@aolose aolose closed this Jan 30, 2022
@aolose aolose changed the title [fix] Server-side fetch request should have headers (#969) [fix] Server-side fetch request should have headers (#696) Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@bluwy bluwy bluwy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aolose @benmccann @bluwy