Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add test cases and fix is_content_type_textual #2781

Merged
merged 8 commits into from
Jan 7, 2022
Merged

[fix] add test cases and fix is_content_type_textual #2781

merged 8 commits into from
Jan 7, 2022

Conversation

si3nloong
Copy link
Contributor

@si3nloong si3nloong commented Nov 11, 2021

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Nothing much, just add more test cases

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021

🦋 Changeset detected

Latest commit: ce4d27e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thank you! mind fixing the lint errors?

for reference, it's helpful if you don't delete the pull request template — it includes a checklist that includes things like linting, and it's useful for maintainers to be able to understand the scope of a PR (whether it requires a version bump, etc)

@vercel
Copy link

vercel bot commented Nov 27, 2021

@si3nloong is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@si3nloong
Copy link
Contributor Author

si3nloong commented Nov 27, 2021

@benmccann can you review it again?

@si3nloong si3nloong changed the title chore: add test cases chore: add test cases and fix is_content_type_textual Nov 27, 2021
@si3nloong si3nloong changed the title chore: add test cases and fix is_content_type_textual [fix] add test cases and fix is_content_type_textual Nov 27, 2021
@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: ce4d27e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d7918b480a5b00078ef25a

@Rich-Harris Rich-Harris merged commit 70f4bc0 into sveltejs:master Jan 7, 2022
@Rich-Harris
Copy link
Member

thanks!

@github-actions github-actions bot mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants