Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use composedPath to find anchor elements #2769

Merged
merged 4 commits into from
Nov 23, 2021
Merged

feat: Use composedPath to find anchor elements #2769

merged 4 commits into from
Nov 23, 2021

Commits on Nov 12, 2021

  1. feat: Use composedPath to find anchor elements 

    The client-side router registers event handlers on mouse movements and
clicks that search anchor elements in an event's target's ancestors to
perform prefetching or routing. The current implementation uses
`parentNode` which "skips" anchor elements in shadow doms.

This change searches instead the `event.composedPath()`, which includes
nodes in open shadow trees.
    @andreavaccari
    andreavaccari committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    39867fa View commit details
    Browse the repository at this point in the history

  2. refactor: find_anchor to receive a full event

    @andreavaccari
    andreavaccari committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    86b17a0 View commit details
    Browse the repository at this point in the history

  3. test: Add integration tests

    @andreavaccari
    andreavaccari committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    25ef41b View commit details
    Browse the repository at this point in the history

  4. docs: Add changeset

    @andreavaccari
    andreavaccari committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    254e3f5 View commit details
    Browse the repository at this point in the history