[chore] upgrade @cloudflare/kv-asset-handler
#2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently run into a bug serving static HTML pages alongside our Svelte app (legacy codebase, working on removing these pages but it takes time) with the following characteristics: 1. First load of a page to behave/run JS one way 2. Refresh/second load of the page using cached assets behave a completely different way This bug appears to only affect webkit desktop browsers, and the page works again if you empty cache and hard reload. We've been able to serve the exact same assets from a simpler Cloudflare worker and everything works as expected, and we've verified that: 1. LocalStorage values are not the culprit 2. Cookies are not used 3. Session state is not used 4. Headers are exactly the same, in Chrome devtools 5. Responses codes and values are exactly the same, in Chrome devtools Manually updating this package appears to fix things, and we're not exactly sure why yet, but it seemed like it would be a good thing to do upstream so that everyone is on the latest. Still digging to try to find a root cause.
🦋 Changeset detectedLatest commit: bf2ce66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
changed the title
@cloudflare/kv-asset-handler
benmccann
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently run into a bug serving static HTML pages alongside our
Svelte app (legacy codebase, working on removing these pages but it
takes time) with the following characteristics:
completely different way
This bug appears to only affect webkit desktop browsers, and the page
works again if you empty cache and hard reload. We've been able to serve
the exact same assets from a simpler Cloudflare worker and everything
works as expected, and we've verified that:
Manually updating this package appears to fix things, and we're not
exactly sure why yet, but it seemed like it would be a good thing to do
upstream so that everyone is on the latest. Still digging to try to find
a root cause.