Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] SSR never option #2529
[feat] SSR never option #2529
Changes from 22 commits
c90fc22
ba8b648
7aab5d4
dc28d89
ce61f66
1e6185e
7fd45bd
4ee0a9c
bc35a2c
a3c0a30
73ebf0d
64947d0
dede251
caf1d52
b78c01b
7ecd93e
bc144a0
5701dd8
d2f7b31
e04e707
87edb89
0e83be9
25ded6c
edbd994
2c86494
86d2d19
f5d4645
9dad824
5d9a94a
023ca9b
cfc5eae
1b4720e
be01755
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any harm in having
metadata_lookup
populated even if it's not used? I wonder if it might be simpler to just leave the code as is and not add an extra condition, but want to make sure I'm not missing anythingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I just thought that it would be better to not populate
metadata_lookup
when it isn't going to be used.