Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid margin-bottom: 0 0 1em 0 #2038

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Remove invalid margin-bottom: 0 0 1em 0 #2038

merged 1 commit into from
Jul 29, 2021

Conversation

Amerlander
Copy link
Contributor

margin-bottom: 0 0 1em 0; seems invalid, so I removed it.

@Amerlander
Remove invalid margin-bottom: 0 0 1em 0
4805c0f 
`margin-bottom: 0 0 1em 0;` seems invalid, so I removed it.
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2021

⚠️ No Changeset found

Latest commit: 4805c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

I would imagine the intention was margin: 0 0 1em 0. I think we want to override the bottom margin to be 1em, but we also want to remove the top margin.

@Amerlander
Copy link
Contributor Author

I first thought the same, but when I did this the layout changes visually. And then I thought the layout got checked visually like a thousand times and therefore it might be better to just remove this line and keep the appearance like it is.

@benmccann
Copy link
Member

I can barely tell the difference, but like it better without

@benmccann benmccann merged commit 77cefe5 into sveltejs:master Jul 29, 2021
@Amerlander Amerlander deleted the patch-1 branch July 29, 2021 23:01
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jul 31, 2021
@sidharthv96
Merge branch 'master' of https://github.com/sveltejs/kit into fix/bas…
d1179e2 
…ePath

* 'master' of https://github.com/sveltejs/kit: (85 commits)
  [chore] minor simplification of `parse_body` (sveltejs#2043)
  Version Packages (next) (sveltejs#2026)
  [chore] deduplicate config types (sveltejs#2030)
  [chore] remove invalid css declaration (sveltejs#2038)
  [fix] correctly pass Vite options in preview mode (sveltejs#2036)
  [feat] Ignore adapter build files (sveltejs#1924)
  [chore] Upgrade Rollup
  Don't check external links on prerender (sveltejs#1679)
  Version Packages (next) (sveltejs#2017)
  [chore] convert remaining type aliases (sveltejs#2018)
  [feat] explicitly set compilerOptions.hydratable to config.kit.hydrate (sveltejs#2024)
  [feat] More powerful and configurable rendering options (sveltejs#2008)
  [chore] typecheck example (sveltejs#2019)
  Change config `prerender.force` to `prerender.onError` (sveltejs#2007)
  [chore] prefer interfaces to types (sveltejs#2010)
  [docs] minor wording improvement in migration guide (sveltejs#2006)
  [chore] test debugging improvements
  [docs] fix typo (sveltejs#2003)
  [chore] use @ts-expect-error instead of @ts-ignore (sveltejs#1999)
  Version Packages (next) (sveltejs#1996)
  ...
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2023
Open
This was referenced May 7, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amerlander @Conduitry @benmccann