-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Ignore adapter build files #1924
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
9d0911e
add api to let adapters modify the user's .gitignore
JeanJPNM b5e2f86
update documentation
JeanJPNM 81994dd
Merge branch 'master' into adapter-file-ignore
JeanJPNM 9c96539
handle changes in ignored files
JeanJPNM 1443779
remove test code
JeanJPNM cb1d390
support updating multiple files
JeanJPNM 7ef9b75
add TODO
JeanJPNM c436c63
add changeset
JeanJPNM 572b1a2
use fs instead of fs/promises
JeanJPNM 9ce434e
update documentation
JeanJPNM 7ad5add
fix error inside loop
JeanJPNM 0440983
fix empty line at the start of a file
JeanJPNM f2571e1
move function to utils object
JeanJPNM 62d4ba5
update adapter-node
JeanJPNM 7d77989
update adapter-static
JeanJPNM b9ebbc0
allow users to comment out ignore patterns
JeanJPNM fe432a7
fix line verification
JeanJPNM 34c65eb
improve delimeter title
JeanJPNM e511a18
update docs
JeanJPNM a75f5ae
update adapter-vercel
JeanJPNM 5817df0
update adapter-cloudfare-workers
JeanJPNM fc0b94b
updata adapter-netlify
JeanJPNM b4f3a1b
update adapter-begin
JeanJPNM ebd3df6
add todo
JeanJPNM 8d6a883
put logging inside function
JeanJPNM 1b8bee2
update adapters
JeanJPNM 191e9c3
split lines with optional \r
JeanJPNM ff76519
check for patterns on the whole file
JeanJPNM 517b254
minimal viable code
JeanJPNM 235e608
remove old comment
JeanJPNM 99fac63
replace \n by EOL
JeanJPNM 14561a1
update docs
JeanJPNM 5e57aae
update adapter api doc
JeanJPNM 57ddbbb
clarify file location
JeanJPNM f581003
undo adapter-begin update
JeanJPNM bd9613d
check for file's eol
JeanJPNM d74eeee
target only .gitignore
JeanJPNM 4403cb9
change ignore path to .gitignore for prettier
JeanJPNM e587a92
Update documentation/docs/80-adapter-api.md
JeanJPNM 4e9c146
update `.gitignore` files on test apps
JeanJPNM cf903e5
update adapter section of documentation
JeanJPNM 50cb7d8
update changeset
JeanJPNM 445b992
add end of line on test apps `.gitignore`
JeanJPNM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': patch | ||
--- | ||
|
||
Add public API to let adapters update .gitignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,5 @@ node_modules | |
/.svelte-kit | ||
/build | ||
/functions | ||
|
||
build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,5 @@ node_modules | |
/.svelte-kit | ||
/build | ||
/functions | ||
|
||
build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"scripts": { | ||
"lint": "prettier --check --plugin-search-dir=. .", | ||
"format": "prettier --write --plugin-search-dir=. ." | ||
"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. .", | ||
"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ." | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also update the templates to use
.gitignore
. It looks likeeslint
might already, but notprettier
. https://github.com/sveltejs/kit/tree/master/packages/create-svelte/shared