Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs and changeset for #11732 #11974

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Mar 12, 2024

cleanup for #11732 by adding a changeset and documentation.

@dario-piotrowicz I tried not to add too much to avoid overcomplicating it but there may be some important details worth mentioning in the docs or a better structure to explain things.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 1eee5c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare-workers Minor
@sveltejs/adapter-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

(except from the wrangler command)

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
…orkers.md

Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
@eltigerchino eltigerchino merged commit 731b03c into main Mar 13, 2024
13 checks passed
@eltigerchino eltigerchino deleted the cloudflare-adapter-dev-leftovers branch March 13, 2024 04:49
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants