Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary @types/cookie package #11375

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

benmccann
Copy link
Member

closes #11350

I don't remember the history of this, but npm run check and pnpm run check both pass without it

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 18be3ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been included because it was needed before #6818 added the types as a dependency for the kit package.

@eltigerchino eltigerchino merged commit fc8389c into master Dec 18, 2023
13 checks passed
@eltigerchino eltigerchino deleted the types-cookies branch December 18, 2023 15:42
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't install @types/cookie in demo app
2 participants