Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make adapter plugin param type optional #11246

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

eltigerchino
Copy link
Member

The types for the cloudflare workers adapter plugin method requires an object as a parameter. This PR makes that optional so it's in tune with the docs https://kit.svelte.dev/docs/adapter-cloudflare-workers#usage

import adapter from '@sveltejs/adapter-cloudflare-workers';

export default {
	kit: {
-		adapter: adapter({ })
+		adapter: adapter()
	}
};

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 071c5fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the base branch from master to version-2 December 9, 2023 16:56
@benmccann benmccann merged commit e2fdf7c into version-2 Dec 9, 2023
10 of 13 checks passed
@benmccann benmccann deleted the fix-cf-worker-adapter-type branch December 9, 2023 16:57
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants