Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide SvelteKit html typings #11222

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

dummdidumm
Copy link
Member

This makes it possible to delete these from svelte/elements in Svelte 5 and have them controled in SvelteKit, decoupling the two
closes #10534

Don't think this is really a breaking change, but let's have it as part of 2.0 just to be sure.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This makes it possible to delete these from svelte/elements in Svelte 5 and have them controled in SvelteKit, decoupling the two
closes #10534
Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: a24c536

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

just a heads up that the tests are failing

@dummdidumm
Copy link
Member Author

@tcc-sejohnson / @gtm-nayan I adjusted the exlude array in the generated tsconfig as part of this PR, I removed the [!ambient.dts] line because I think it's unnecessary (and I don't know how to add non-ambient.d.ts in there 😅 ). exclude will only exclude things that were pulled in by include, and include isn't written in a way that pulls in more than those two d.ts files. Does that sound sensible to you? (Tagging you too because IIRC you both worked in this area before)

@benmccann benmccann added this to the 2.0 milestone Dec 8, 2023
@benmccann benmccann linked an issue Dec 9, 2023 that may be closed by this pull request
@dummdidumm
Copy link
Member Author

Ok I checked whe the exclude came from, and it's there since the beginning of time, but I still don't see how it makes sense to have it like that, so I'm merging this.

@dummdidumm dummdidumm merged commit a93a39f into version-2 Dec 11, 2023
13 checks passed
@dummdidumm dummdidumm deleted the provide-own-sveltekit-typings branch December 11, 2023 18:58
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide augmented HTML typings in SvelteKit itself
3 participants