-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove top level promise await behavior #11176
Conversation
🦋 Changeset detectedLatest commit: 7a17acd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It looks like maybe the generated types don't allow |
Having fixed two tests, and seing that it's a bit tough to ergonomically do this, I'm wondering if we should provide the function we used previously as a helper that you can import? |
the site deploy failure looks like a real bug, though i'm a bit confused by it |
oh it's because the site has a |
this LGTM — should it still be draft, or can we merge? |
I think we can merge, AFAIK it was in draft Mode because of type failures which I fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait. this one needs a changeset still
Closes #10106
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.