Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init command in starter app on about page #1105

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

Conduitry
Copy link
Member

The about page on the create-svelte template said npx init svelte@next rather than npm init svelte@next. It also apparently hadn't been formatted correctly by Prettier when it was last saved. I'm torn about whether this should include a subdirectory to create, like we're doing elsewhere in the docs. Maybe?

Changesets are currently messed up, so for now one is not included in here. This package is called ~TODO~ as far as changesets can tell. I've manually edited the included changeset file and will try to look into what's going on here separately.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Apr 18, 2021

@Conduitry is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Rich-Harris Rich-Harris merged commit daf6913 into sveltejs:master Apr 18, 2021
@Conduitry Conduitry deleted the template-fix-init-command branch April 18, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants