Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure glob finds all files in folders #10230

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

dummdidumm
Copy link
Member

For some reason {folders.value.join(',')} as part of the glob doesn't work and returns less files fixes #10228

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

For some reason {folders.value.join(',')} as part of the glob doesn't work and returns less files
fixes #10228
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 73a4371

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@gtm-nayan gtm-nayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, odd that the previous syntax doesn't work.

@dummdidumm
Copy link
Member Author

yeah, super odd, but it was clearly visible when logging out the matched files

@dummdidumm dummdidumm merged commit 2afbe91 into master Jun 23, 2023
@dummdidumm dummdidumm deleted the migration-glob branch June 23, 2023 09:25
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-migrate transition omission
2 participants