Build fails using adapter-vercel #7245
Labels
Comments
|
Can you add a |
dummdidumm
added
pkg:adapter-vercel
|
|
That sounds like something inside |
package.json: |
|
What happens if you adjust the code in // replace line 318 with
const result = match.exec(error.message);
if (!result) {
return;
}The build probably succeeds then, I'm wondering if this has any impact on your deployed app. |
|
Sorry, had to sleep ;) Hopefully I did that right: if (error.message.startsWith('Failed to resolve dependency')) {
const match = /Cannot find module '(.+?)' loaded from (.+)/;
console.log(error.message)
// const [, module, importer] = match.exec(error.message);
//
// if (!resolution_failures.has(importer)) {
// resolution_failures.set(importer, []);
// }
const result = match.exec(error.message);
if (!result) {
return;
}
resolution_failures.get(importer).push(module);
} else {
throw error;
}I am getting this: |
|
Sorry, I didn't paste the full code, there's one line missing at the end. It should be if (error.message.startsWith('Failed to resolve dependency')) {
const match = /Cannot find module '(.+?)' loaded from (.+)/;
console.log(error.message)
// const [, module, importer] = match.exec(error.message);
//
// if (!resolution_failures.has(importer)) {
// resolution_failures.set(importer, []);
// }
const result = match.exec(error.message);
if (!result) {
return;
}
const [, module, importer] = result; // <- was missing
resolution_failures.get(importer).push(module);
} else {
throw error;
} |
|
Ah that makes more sense. Here's a new one: |
|
I should have read that code snippet more closely ... 😄 This one goes through hopefully.. if (error.message.startsWith('Failed to resolve dependency')) {
const match = /Cannot find module '(.+?)' loaded from (.+)/;
console.log(error.message)
// const [, module, importer] = match.exec(error.message);
const result = match.exec(error.message);
if (!result) {
return;
}
const [, module, importer] = result;
if (!resolution_failures.has(importer)) {
resolution_failures.set(importer, []);
}
resolution_failures.get(importer).push(module);
} else {
throw error;
} |
|
Ok, the build did go through with that, but I did get this at the end. I guess I should try to deploy this, but I'll have to figure out how to deploy manually to vercel since I have just been using the GH action 🤣. |
|
Hmmm, as far as I can tell from the docs, the only "manual" deployments are using the cli which just uploads the source code to vercel to build it. So, none of the changes to npm packages of course. Is there a simple(ish) way to temporarily swap it out? |
|
https://www.npmjs.com/package/patch-package this should do the job |
|
Success! What does this mean for adapter-vercel? Is this change good for everyone using the package? If so, I can create a pr with the change. |
|
I created vercel/nft#315 first because I think that's the source of this issue |
dummdidumm
added a commit
that referenced
this issue
Oct 19, 2022
5 tasks
Rich-Harris
pushed a commit
that referenced
this issue
Oct 19, 2022
|
So I updated my app to use this new version without the patch. Build works, but now I get this cryptic error message. |
|
Yes, we left that in as a warning to notify people that something may not work - but if it does you can ignore it. It's a warning, not an error, so the build succeeds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I am working on updating one of my apps (from 367). Finally got it all working in
pnpm dev, so I go to build and... fail. I have been racking my brain but unfortunately I haven't been able to pin down exactly why. It seems that it is something with the adapter itself, but obviously not all adapter-vercel builds are failing, so maybe it is something on my end. Ahh! 😕 Maybe this has been seen before and there is a known solution? 🤞🏻The vite part of the build works fine, so
pnpm previewworks, just not the final build. I have also tried building with adapter-node which worked as expected and even adapter-netlify which worked, although I did not deploy it.Reproduction
Sorry, no repro. I have not been able to pin down exactly what is causing this. Feel free to close I guess but just frustrating since I deploy to vercel. I would just say it is obviously something on my end, but it is weird that adapter-node and adapter-netlify build successfully if that is the case.
Logs
System Info
System: OS: macOS 12.6 CPU: (10) arm64 Apple M1 Max Memory: 1.45 GB / 32.00 GB Shell: 5.8.1 - /bin/zsh Binaries: Node: 16.17.0 - ~/.nodenv/versions/16.17.0/bin/node Yarn: 1.22.15 - ~/.nodenv/shims/yarn npm: 8.15.0 - ~/.nodenv/versions/16.17.0/bin/npm Browsers: Chrome: 106.0.5249.119 Firefox: 105.0.3 Safari: 16.0 npmPackages: @sveltejs/adapter-netlify: ^1.0.0-next.80 => 1.0.0-next.80 @sveltejs/adapter-node: ^1.0.0-next.97 => 1.0.0-next.97 @sveltejs/adapter-vercel: ^1.0.0-next.78 => 1.0.0-next.78 @sveltejs/kit: ^1.0.0-next.514 => 1.0.0-next.514 svelte: ^3.51.0 => 3.51.0 vite: ^3.1.7 => 3.1.7Severity
blocking all usage of SvelteKit
Additional Information
No response
The text was updated successfully, but these errors were encountered: