After SvelteKit 1.0.0-next.397, build hangs without displaying errors

[nstuyvesant]

Describe the bug

After upgrading to any version of SvelteKit after 1.0.0-next.397, when running npm run build (vite build), it gets to a specific point in the process then never completes. No error messages:

% npm run build

> shy-svelte@3.0.3 build
> vite build

vite v3.0.4 building for production...
✓ 1737 modules transformed.

I am using vite@3.0.4 and @sveltejs/adapter-node@1.0.0-next.85. The version of these packages appears to have no effect on the inability to complete the build.

Reproduction

1. git clone https://github.com/nstuyvesant/shy-svelte.git
2. cd shy-svelte
3. Change version of @sveltejs/kit to 1.0.0-next.398 in package.json (or change to "latest")
4. npm install
5. npx vite build (or npm run build) - use first one if you don't want to include my post-build script (will reproduce issue easily)

This build will never complete (or throw an error).

Change the SvelteKit version back to 1.0.0-next.397 and retry. Build will complete without problems.

Logs

% npm run build

> shy-svelte@3.0.3 build
> vite build

vite v3.0.4 building for production...
✓ 1737 modules transformed.

System Info

System:
    OS: macOS 12.4
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.90 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - /opt/homebrew/bin/node
    npm: 8.15.1 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 102.0.1
    Safari: 15.5
  npmPackages:
    @sveltejs/adapter-node: latest => 1.0.0-next.85 
    @sveltejs/kit: 1.0.0-next.397 => 1.0.0-next.397 
    svelte: ^3.49.0 => 3.49.0 
    vite: ^3.0.4 => 3.0.4

Severity

blocking an upgrade

Additional Information

Another person on Discord ran into this with their project as well. A change in 1.0.0-next.398 in combination with my project seems to be the cause.

[dummdidumm]

I'm very surprised that a duplicate reference to types makes this hang - wonder what's going on there. AFAIK vite doesn't even try to type-check, so why would it interfere with the build?

[nstuyvesant]

Actually - my mistake as I neglected to do an npm update so it was working with 1.0.0-next.397 (but not thereafter). So it's still an issue.

[benmccann]

Three changes in 398: https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md#100-next398

[elliott-with-the-longest-name-on-github]

Three changes in 398: https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md#100-next398

I'll try to take a look at this today. My bet is that the illegal module analysis may be entering a cyclical import and not breaking out like it should.

[nstuyvesant]

On discord, saw some comments about builds getting very long (went from 30 seconds to 15 minutes) after 1.0.0-next.397. Perhaps related?

[benmccann]

@tcc-sejohnson I think that is the cause. The build completes when I comment out the call to prevent_illegal_rollup_imports in writeBundle

There's another reproduction in #5784 (comment) that might have a few less dependencies in case it's any easier to debug against

[cryptosmithio]

I am seeing this too, but it's not hanging, just amazingly slow. For me, findSvelteDependencies takes around 15 minutes. Please find attached output of my build process. Line 1018 takes ~18 minutes.
build.out.txt

If if I downgrade to 1.0.0-next.397, my build is fine.

[nstuyvesant]

@jiyosub - Was looking at your build.out.txt - there is a private key in it so you should probably remove the file from your comment. I will delete what I just downloaded and wash my eyes out ;-)

[cryptosmithio]

Thanks. Fixed that and rotated those keys. (Just vite dev server keys, but better safe than sorry)

[cryptosmithio]

On discord, saw some comments about builds getting very long (went from 30 seconds to 15 minutes) after 1.0.0-next.397. Perhaps related?

That was mine.

[nstuyvesant]

Thanks! My build just completed with 1.0.0-next.402

[helmar81]

Having similar issue:
error during build:
Error: ENOTEMPTY: directory not empty, rmdir '\?\C:\Users\User\my-CV.svelte-kit\output\server\chunks'