Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp should be replaced with version in service workers #4196

Closed
Rich-Harris opened this issue Mar 3, 2022 · 0 comments · Fixed by #4213
Closed

timestamp should be replaced with version in service workers #4196

Rich-Harris opened this issue Mar 3, 2022 · 0 comments · Fixed by #4213
Labels
feature / enhancement New feature or request
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the problem

#3412 added a version export to $app/env, which defaults to the timestamp at the time of builld. The $service-worker module doesn't expose it — it instead exposes a different timestamp.

Describe the proposed solution

Add version to $service-worker, and replace timestamp with an object that will throw a noisy error if you try to stringify it (which will cover the common case where it's used as a cache key).

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@Rich-Harris Rich-Harris added the feature / enhancement New feature or request label Mar 3, 2022
@benmccann benmccann added this to the 1.0 milestone Mar 3, 2022
Rich-Harris added a commit that referenced this issue Mar 5, 2022
* replace timestamp in $service-worker with version - fixes #4196

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants