only cache response if response has cache-control header (#9885)

* only cache response if response has cache-control header * add changeset
sveltejs · May 17, 2023 · a309d1c · a309d1c
1 parent b3539c5
commit a309d1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/tidy-worms-reflect.md b/.changeset/tidy-worms-reflect.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/adapter-cloudflare': patch
+---
+
+fix: require explicit cache-control header for caching
diff --git a/packages/adapter-cloudflare/src/worker.js b/packages/adapter-cloudflare/src/worker.js
@@ -55,7 +55,8 @@ const worker = {
 
 		// write to `Cache` only if response is not an error,
 		// let `Cache.save` handle the Cache-Control and Vary headers
-		return res.status >= 400 ? res : Cache.save(req, res, context);
+		pragma = res.headers.get('cache-control') || '';
+		return pragma && res.status < 400 ? Cache.save(req, res, context) : res;
 	}
 };