Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

fix: Replace @tailwind directives for @import #492

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

AdrianGonz97
Copy link
Collaborator

@AdrianGonz97 AdrianGonz97 commented Jul 19, 2024

Addresses one of the issues from #482

Replaces the tailwind directives:

@tailwind base;
@tailwind components;
@tailwind utilities;

for imports:

@import "tailwindcss/base";
@import "tailwindcss/components";
@import "tailwindcss/utilities";

This was done for better compatibility when the adder is used in preexisting projects that have @import rules already applied. See #482 (comment) for more details.

Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 96372d7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jul 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 96372d7

svelte-add

npm i https://pkg.pr.new/svelte-add/svelte-add@492

@svelte-add/website

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/website@492


templates

benmccann
benmccann previously approved these changes Jul 20, 2024
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I thought it was a bit non-standard at first not to use @tailwind, but since it's the way things will be done for Tailwind 4 I think it's fine

.changeset/funny-glasses-pump.md Outdated Show resolved Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@manuel3108 manuel3108 merged commit 470dc1f into main Jul 23, 2024
5 checks passed
@manuel3108 manuel3108 deleted the fix/tailwind-imports branch July 23, 2024 15:31
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants