Moving clang-format installation from script to dockerfile

[bam241]

clang-format was previously installed in the housekeeping script.

this make more sense to install it preventively in the docker countainer

[bam241]

this will need the docker container to be update to actually pass... (clang-format will not be in the container...)

[gonuke]

Did you manually update the docker images to support testing on this?

[bam241]

I did not yet, but we will have to

[gonuke]

How are tests passing then?

[bam241]

it is actually quietly failing:

find: 'clang-format': No such file or directory
find: 'clang-format': No such file or directory
find: 'clang-format': No such file or directory
find: 'clang-format': No such file or directory

[gonuke]

Do we still need this? update this PR? start over? abandon?

[bam241]

we probably still need as our housekeeping script still installs clang-format each time it runs....

[bam241]

docker build on my side do net trigger for the last commit...

[gonuke]

This looks good to me. After #771, the images should build properly on your side. Or you can add back the blank line before jobs in the docker_publish.yml

[gonuke]

rebase here and then we can confirm that the images build correctly

[bam241]

I did rebased 3 time... the wrong branch :p

[gonuke]

I'm monitoring your test builds to merge this when it works

[gonuke]

Thanks @bam241 - this all build & tested fine