Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3389 #52

Merged
merged 3 commits into from
Jun 8, 2024
Merged

A3389 #52

merged 3 commits into from
Jun 8, 2024

Conversation

morganvenable
Copy link

3389 addition to folders and ci cd

@morganvenable morganvenable requested a review from ilc June 5, 2024 04:42
@ilc ilc mentioned this pull request Jun 5, 2024
Closed
ilc
ilc reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ilc ilc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, rules.mk could use cleaning up in the 3360 and 3389 directories, but that work can be deferred if merging is urgent.

@morganvenable
Copy link
Author

@ilc fixed makefiles

ilc
ilc approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@ilc ilc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilc ilc merged commit dc13cc8 into svalboard:vial Jun 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilc ilc ilc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morganvenable @ilc