forked from vial-kb/vial-qmk
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplo - The realization of Lego. #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lego is the ability to compose Svalboard firmwares like legos. Ballpoint and pointball disappear. Because they are just a trackball firmware and a trackpoint firmware, flashed on the correct sides. If there is a blank, it can not be master. Point/point is now a vaild config. DPI Setting for PS/2 is disabled until we figure out how not to have it break the world.
Drift correction got broken with lego. This fixes it.
morganvenable
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this works on all my configurations and fixed tlvenn's weird flashing issue, which is good enough for me to cut over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges:
The QMK PR that makes PS2 into a pointing device and lego, which makes svalboard firmware composable.
No more ballpoint or pointball. Grab the right firmware for each side and go.
Trackpoint support on the sub side is preliminary, and may need some tweaks to get into final form. (Mainly fix drift.)