Support buffering simple values without alloc (#183)

sval-rs · Dec 21, 2023 · e681eb3 · e681eb3
1 parent 65dd466
commit e681eb3
Show file tree

Hide file tree

Showing 5 changed files with 1,635 additions and 1,700 deletions.
diff --git a/.github/workflows/buffer.yml b/.github/workflows/buffer.yml
@@ -62,3 +62,23 @@ jobs:
       - name: Powerset
         working-directory: ./buffer
         run: cargo hack check --each-feature --exclude-features std,alloc -Z avoid-dev-deps --target thumbv6m-none-eabi
+
+  miri:
+    name: Test (Miri)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
+
+      - name: Install Miri
+        run: |
+          rustup toolchain install nightly --component miri
+          cargo +nightly miri setup
+
+      - name: Default features
+        working-directory: ./buffer
+        run: cargo +nightly miri test --lib
+
+      - name: No features
+        working-directory: ./buffer
+        run: cargo +nightly miri test --lib --no-default-features
diff --git a/buffer/src/error.rs b/buffer/src/error.rs
@@ -15,12 +15,10 @@ enum ErrorKind {
     InvalidValue {
         reason: &'static str,
     },
-    #[cfg(feature = "alloc")]
     OutsideContainer {
         method: &'static str,
     },
-    #[cfg(not(feature = "alloc"))]
-    #[allow(dead_code)]
+    #[allow(dead_code)] // debug builds never reach this variant
     NoAlloc {
         method: &'static str,
     },
@@ -35,11 +33,9 @@ impl fmt::Display for Error {
             ErrorKind::InvalidValue { reason } => {
                 write!(f, "the value is invalid: {}", reason)
             }
-            #[cfg(feature = "alloc")]
             ErrorKind::OutsideContainer { method } => {
                 write!(f, "expected a fragment while buffering {}", method)
             }
-            #[cfg(not(feature = "alloc"))]
             ErrorKind::NoAlloc { method } => write!(f, "cannot allocate for {}", method),
         }
     }
@@ -50,7 +46,6 @@ impl Error {
         Error(ErrorKind::Unsupported { actual, expected })
     }
 
-    #[cfg(feature = "alloc")]
     pub(crate) fn outside_container(method: &'static str) -> Self {
         Error(ErrorKind::OutsideContainer { method })
     }
@@ -62,7 +57,6 @@ impl Error {
         Error(ErrorKind::InvalidValue { reason })
     }
 
-    #[cfg(not(feature = "alloc"))]
     #[track_caller]
     pub(crate) fn no_alloc(method: &'static str) -> Self {
         /*