Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if the HEAD sha is latest #1174

Merged
merged 8 commits into from
Sep 24, 2023
Merged

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Sep 24, 2023

Updated list-targets and setup action.
Validate if the current workflow run's head sha ${{github.event.pull_request.head.sha}} is same with the pull request's latest head sha.

If the head sha is old, the workflow would fail.

This validation prevents old workflow run is retried.
Retrying old workflow run confuses us because old workflow run's results are posted to the pull request as if the latest result.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Sep 24, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v0.6.10 milestone Sep 24, 2023
@suzuki-shunsuke
Copy link
Owner Author

I found we can't validate the commit hash with cached ci-info result in setup action.

@suzuki-shunsuke suzuki-shunsuke merged commit 807749c into main Sep 24, 2023
@suzuki-shunsuke suzuki-shunsuke deleted the fix-check-head-sha branch September 24, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant