feat: add support for CRITICAL severity type #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kei711
force-pushed
the
feature/severity-critical
branch
from
24a1c6c
to
c7a5e36
Compare
|
Thank you for your contribution! |
suzuki-shunsuke
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug described below.
The tfsec result contains a CRITICAL severity type.
However, there is no route to convert it to reviewdog format, so the following error occurs
reviewdog: parse error: failed to unmarshal rdjson (DiagnosticResult): proto: (line 1:1197): invalid value for enum type: ""Refs: reviewdog severity types:
Example tfsec output for CRITICAL severity type:
{ "rule_id": "AVD-GCP-0044", "long_id": "google-compute-no-default-service-account", "rule_description": "Instances should not use the default service account", "rule_provider": "google", "rule_service": "compute", "impact": "Instance has full access to the project", "resolution": "Remove use of default service account", "links": [ "https://aquasecurity.github.io/tfsec/v1.15.4/checks/google/compute/no-default-service-account/", "https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance#" ], "description": "Instance uses the default service account.", "severity": "CRITICAL", "status": 0, "resource": "google_compute_instance.vm", "location": { "filename": "/home/runner/work/terraform/main.tf", "start_line": 114, "end_line": 117 } },