Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update unit test using tap #44 #73

Merged
merged 1 commit into from
Oct 11, 2024
Merged

chore: update unit test using tap #44 #73

merged 1 commit into from
Oct 11, 2024

Conversation

dittybijil
Copy link
Contributor

Added more unit test

@dittybijil dittybijil closed this Oct 11, 2024
@dittybijil dittybijil reopened this Oct 11, 2024
@pradeepcdlm pradeepcdlm merged commit 20a1600 into surveilr:main Oct 11, 2024
@shah
Copy link
Contributor

shah commented Oct 13, 2024

@dittybijil @razakpm @pradeepcdlm there is a high amount of copy/paste for similar functionality. Please create a method called assertTable and another method called assertView which you can add to the base class and pass in a list of table names and/or views which would then be called without duplicating code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dittybijil @shah @pradeepcdlm