Perf: Replace TwigNode vector with BTreeMap #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current issue with versioning was due to the usage of vector inside a twignode to maintain all versions. As the vector grows larger, this was taking significant time and became worse as reported during surrealkv reload. This PR replaces the vector with a btreemap, and adds a reverse map from timestamp to version to make timestamp queries faster. There is a significant improvement as you can see.
But this comes at a cost of slow down in insertion time. Keeping the PR for future reference.
on
main
:on this branch: