Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag datetime fix #155

Merged
merged 15 commits into from
Feb 4, 2025
Merged

Tag datetime fix #155

merged 15 commits into from
Feb 4, 2025

Conversation

maxwellflitton
Copy link
Contributor

What is the motivation?

Adding support for isoformat dates with DatetimeWrapper and IsoDateTimeWrapper classes.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

What does this change do?

Provides serialisation for datetimes for cbor

What is your testing strategy?

unit tests written in the tests/unit_tests/data_types/test_datetimes.py file. Here we have a wrapper that handles the serialization of datetime. I've tried to overwrite the default serialization but this was no possible so I had to use wrapper classes.

Is this related to any issues?

#144

Have you read the Contributing Guidelines?

@maxwellflitton maxwellflitton merged commit 0a4b364 into main Feb 4, 2025
29 checks passed
@maxwellflitton maxwellflitton deleted the tag-fix branch February 4, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant