Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #25 #32

Merged
merged 1 commit into from
Jun 14, 2018
Merged

fix #25 #32

merged 1 commit into from
Jun 14, 2018

Conversation

ryanwitt
Copy link
Member

@ryanwitt ryanwitt commented Jun 14, 2018 •
edited
Loading

Looks like node's child_process.exec timeout option only kills the immediate shell and not the shell's children. This PR uses tree-kill to ensure the entire tree is dead when qdone says it should be.

@ryanwitt ryanwitt changed the title hopefully fix #25 fix #25 Jun 14, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 92.494% when pulling 6a509db on github-25 into 146d0e4 on master.

@ryanwitt ryanwitt merged commit 40c598d into master Jun 14, 2018
@ryanwitt ryanwitt deleted the github-25 branch June 14, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanwitt @coveralls