Feat: materi 3 chapter 2 (css grid layout) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sbydev-kelas-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iniakunhuda
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Ada beberapa feedback yang perlu diperbaiki sedikit lagi mas
- Materi "Properti Display Grid" di tantangan numberingnya start mulai dari 1
- Materi "Properti Display Grid" dan "Contoh layout dengan Grid dan Flexbox" tolong tambahkan image (result) di bawah tantangan agar user kebayang bagaimana expected result yang harus dibuat
Taruh file di folder _assets, bisa melihat caranya disini
Okay mas Huda |
…image untuk content.md pada folder _assets
|
LGTM |
|
Overall content is great, please next time pull request to branch staging ya mas @yudistiraashadi. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request untuk #10 tutorial css grid layout. Tag @iniakunhuda