Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread background color stand out in dark theme. #863

Closed
nyoronjp opened this issue Sep 20, 2017 · 2 comments
Closed

Unread background color stand out in dark theme. #863

nyoronjp opened this issue Sep 20, 2017 · 2 comments
Labels
[Status] 2.done (create pull request) [Type] 1.requirement
Milestone
v1.11

Comments

@nyoronjp
Copy link
Contributor

未読の背景色がダークテーマだと目立つ。

Knowledge v1.11.0 pre1

darktheme

knowledge-list.css

.unread {
    background-color: #e5fcff;
}
@koda-masaru
Copy link
Contributor

確かに。。。

ダークテーマのときは、背景色を切り替えられるような仕組みを考えますね。

@koda-masaru koda-masaru added this to the v1.12 milestone Oct 9, 2017
koda-masaru added a commit that referenced this issue Oct 9, 2017
@koda-masaru
#863 Change unread style on dark thema
b955a14
koda-masaru added a commit that referenced this issue Oct 9, 2017
@koda-masaru
Merge pull request #894 from support-project/issue863_dark_style
646211d 
#863 Change unread style on dark thema
@koda-masaru koda-masaru modified the milestones: v1.12, v1.11 Oct 10, 2017
@nyoronjp
Copy link
Contributor Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] 2.done (create pull request) [Type] 1.requirement
Projects
None yet
Milestone
v1.11
Development

No branches or pull requests
2 participants
@nyoronjp @koda-masaru