-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] update config types to use bytesize.Size #828
[feature] update config types to use bytesize.Size #828
Conversation
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Okay turns out mapstructure is angery and doesn't handle the decoding properly. Grrr. |
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
@tsmethurst I am so confused as to why the pipeline is failing. running |
You're running go 1.19 now right? This PR is still building/testing/etc on 1.18 |
This is true! Though I think I just managed to catch and fix the error now, related to a small change I made in envparsing :) |
^ this is what I get for attempting to edit and fix things from my phone using the GitHub text editor lmao |
…e-config-vars Signed-off-by: kim <grufwub@gmail.com>
@tsmethurst how do we feel about merging this one? :) |
I feel good about it, BUT we should probably fix the broken snapshot build first, looks like swagger is not in the path for some reason? https://drone.superseriousbusiness.org/superseriousbusiness/gotosocial/2834/1/2 |
how on earth 🤔 i'll take a look into this tomorrow |
One thing I forgot to ask earlier: will this require users to update their configs? or is it backwards compatible? |
…' into improvement/bytesize-config-vars
Allows passing
40MiB
,40MB
,1kiB
etc instead of literal sizes in bytes. Also updates some of the file sizes returned in the codebase to beint64
and notint
.