[chore] update dependencies, bump to Go 1.19.1 #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
done! also signed it for ya also bumped golangci-lint and guess what 😈 there's linter errors |
|
Swagger docs fixed, go fmt can be run now without fucking them up. Will fix the lint issues next... |
|
It's passing linting now, but tests now fail/timeout. Seems to block on a channel now: @NyaaaWhatsUpDoc Could you take a look at this? |
Signed-off-by: kim <grufwub@gmail.com>
|
figured out the issue for the follow request reject test! the test processor wasn't being started so enqueuing a worker function blocked as there was nothing to pick it up. |
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
|
That should be the remainder of the tests fixed now, in all cases it was the processor not being started. I'm not 100% sure why it had worked previously, but this change basically just brought to light cases where we were passing things when processors were not started |
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Right?? That's bonkers |
|
Closes #831 We should merge this after the remaining 0.5.x issues and include it in 0.6.x |
|
An update on the bun stuff, I investigated and the breakage from upstepping bun comes from this commit: uptrace/bun@177ec4c so previously the statement for creating the media_attachments table looked like this: CREATE TABLE "media_attachments" ("id" CHAR(26) NOT NULL, "created_at" timestamptz NOT NULL DEFAULT current_timestamp, "updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "status_id" CHAR(26), "url" VARCHAR, "remote_url" VARCHAR, "type" VARCHAR NOT NULL, "original_width" INTEGER, "original_height" INTEGER, "original_size" INTEGER, "original_aspect" DOUBLE PRECISION, "small_width" INTEGER, "small_height" INTEGER, "small_size" INTEGER, "small_aspect" DOUBLE PRECISION, "focus_x" REAL, "focus_y" REAL, "account_id" CHAR(26) NOT NULL, "description" VARCHAR, "scheduled_status_id" CHAR(26), "blurhash" VARCHAR, "processing" INTEGER NOT NULL DEFAULT 2, "file_path" VARCHAR NOT NULL, "file_content_type" VARCHAR NOT NULL, "file_file_size" INTEGER NOT NULL, "file_updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "thumbnail_path" VARCHAR NOT NULL, "thumbnail_content_type" VARCHAR NOT NULL, "thumbnail_file_size" INTEGER NOT NULL, "thumbnail_updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "thumbnail_url" VARCHAR, "thumbnail_remote_url" VARCHAR, "avatar" BOOLEAN NOT NULL DEFAULT false, "header" BOOLEAN NOT NULL DEFAULT false, "cached" BOOLEAN NOT NULL, PRIMARY KEY ("id"), UNIQUE ("id"))and now it looks like this: CREATE TABLE IF NOT EXISTS "media_attachments" ("id" CHAR(26) NOT NULL, "created_at" timestamptz NOT NULL DEFAULT current_timestamp, "updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "status_id" CHAR(26), "url" VARCHAR, "remote_url" VARCHAR, "type" VARCHAR NOT NULL, "filemeta_original_width" INTEGER, "filemeta_original_height" INTEGER, "filemeta_original_size" INTEGER, "filemeta_original_aspect" DOUBLE PRECISION, "filemeta_small_width" INTEGER, "filemeta_small_height" INTEGER, "filemeta_small_size" INTEGER, "filemeta_small_aspect" DOUBLE PRECISION, "filemeta_focus_x" REAL, "filemeta_focus_y" REAL, "account_id" CHAR(26) NOT NULL, "description" VARCHAR, "scheduled_status_id" CHAR(26), "blurhash" VARCHAR, "processing" INTEGER NOT NULL DEFAULT 2, "file_path" VARCHAR NOT NULL, "file_content_type" VARCHAR NOT NULL, "file_file_size" INTEGER NOT NULL, "file_updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "thumbnail_path" VARCHAR NOT NULL, "thumbnail_content_type" VARCHAR NOT NULL, "thumbnail_file_size" INTEGER NOT NULL, "thumbnail_updated_at" timestamptz NOT NULL DEFAULT current_timestamp, "thumbnail_url" VARCHAR, "thumbnail_remote_url" VARCHAR, "avatar" BOOLEAN NOT NULL DEFAULT false, "header" BOOLEAN NOT NULL DEFAULT false, "cached" BOOLEAN NOT NULL DEFAULT false, PRIMARY KEY ("id"), UNIQUE ("id"))so the difference is that now the media_attachment fields that have the options for fixing this are:
[edit] For now I fixed this here -- a040e17. This makes the behavior of bun for this particular model work the same as before. |
…cial into chore/update-deps
Signed-off-by: kim <grufwub@gmail.com>
|
@tsmethurst can merge now? :D |
|
Go for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we can't update our
uptrace/bunversion as there seems to be another breaking changing going from 1.17 -> 1.18 😭We will also need to bump the Go build version in: https://github.com/superseriousbusiness/gotosocial-drone-build/blob/main/.drone.yml