-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] colorscheme redesign, some other small css tweaks #811
Conversation
Excited about this one 👀 |
I had a read through! Looks good so far. Some things that come to mind: With the new unexpanded status layout, what happens if someone has a really long display name? does it smush into the date? And what do unexpanded statuses with show more / show less buttons look like? For color variable names, instead of |
Needs a bit of a fix still, but we can cut off the displayname with an ellipsis. Was also thinking it might be nice to have a smaller date format (with relative times), so then it takes up less space too.
I'm considering adding a bit more proxy variables for that, we kind of already do, with colors, names for colors, specific locations that use those names.
|
I think relative time works better in clients than it does via a web UI, but we could definitely shorten the date format a bit in other ways (maybe just show like I'd say more proxy variables aren't necessarily required (though it's fine if so); imo the important thing is to just not name variables after certain colors, because it makes it more confusing when users/admins wanna write custom css in the future, if you get me |
|
Sure :) That's a good idea |
This PR is kind of tangled with #812, so I'd rather get that merged first then adapt the discussion mentioned here in a new PR |
Alright, sounds good! 😊
Sent from ProtonMail mobile
…-------- Original Message --------
On Sep 19, 2022, 6:31 PM, f0x52 wrote:
This PR is kind of tangled with [#812](#812), so I'd rather get that merged first then adapt the discussion mentioned here in a new PR
—
Reply to this email directly, [view it on GitHub](#811 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHT24I3NQKWRIYSVQGNMTHLV7CINHANCNFSM6AAAAAAQIGY3GA).
You are receiving this because you commented.Message ID: ***@***.***>
|
Still kind of a work in progress, trying to pick a better color palette, and to document how those can be combined to maintain predictable contrast ratios.
Needs some more checking, especially with HTML/Markdown formatted posts I think