Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] colorscheme redesign, some other small css tweaks #811

Closed
wants to merge 3 commits into from

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Sep 8, 2022

Still kind of a work in progress, trying to pick a better color palette, and to document how those can be combined to maintain predictable contrast ratios.

image
image
image
image

Needs some more checking, especially with HTML/Markdown formatted posts I think

@f0x52 f0x52 added frontend Frontend-related stuff accessibility labels Sep 8, 2022
@tsmethurst
Copy link
Contributor

Excited about this one 👀

@tsmethurst
Copy link
Contributor

I had a read through! Looks good so far. Some things that come to mind:

With the new unexpanded status layout, what happens if someone has a really long display name? does it smush into the date? And what do unexpanded statuses with show more / show less buttons look like?

For color variable names, instead of white, gray, orange, and blue, perhaps they could be foreground, background, accent, and trim, or something like that? Then it'll be less confusing if someone wants to change their foreground color to black and background to white, etc. Whaddya think?

@f0x52
Copy link
Contributor Author

f0x52 commented Sep 9, 2022

With the new unexpanded status layout, what happens if someone has a really long display name? does it smush into the date? And what do unexpanded statuses with show more / show less buttons look like?

Needs a bit of a fix still, but we can cut off the displayname with an ellipsis. Was also thinking it might be nice to have a smaller date format (with relative times), so then it takes up less space too.

For color variable names, instead of white, gray, orange, and blue, perhaps they could be foreground, background, accent, and trim, or something like that? Then it'll be less confusing if someone wants to change their foreground color to black and background to white, etc. Whaddya think?

I'm considering adding a bit more proxy variables for that, we kind of already do, with colors, names for colors, specific locations that use those names.
so

$orange1: blah;
$accent: $orange1;
$avatar-border: $accent;

@tsmethurst
Copy link
Contributor

tsmethurst commented Sep 10, 2022

it might be nice to have a smaller date format (with relative times), so then it takes up less space too.

I think relative time works better in clients than it does via a web UI, but we could definitely shorten the date format a bit in other ways (maybe just show like 10/09/22 - 13:36 or something?).

I'd say more proxy variables aren't necessarily required (though it's fine if so); imo the important thing is to just not name variables after certain colors, because it makes it more confusing when users/admins wanna write custom css in the future, if you get me

@f0x52
Copy link
Contributor Author

f0x52 commented Sep 10, 2022

I think relative time works better in clients than it does via a web UI, but we could definitely shorten the date format a bit in other ways (maybe just show like 10/09/22 - 13:36 or something?).
Yeah that'd help, maybe also shortening it to just the time if it's the same day?

I'd say more proxy variables aren't necessarily required (though it's fine if so); imo the important thing is to just not name variables after certain colors, because it makes it more confusing when users/admins wanna write custom css in the future, if you get me
Fair, that does make it easier/more logical to change a shade everywhere in one change

@tsmethurst
Copy link
Contributor

Yeah that'd help, maybe also shortening it to just the time if it's the same day?

Sure :) That's a good idea

@f0x52
Copy link
Contributor Author

f0x52 commented Sep 19, 2022

This PR is kind of tangled with #812, so I'd rather get that merged first then adapt the discussion mentioned here in a new PR

@tsmethurst
Copy link
Contributor

tsmethurst commented Sep 19, 2022 via email

@f0x52 f0x52 closed this Sep 19, 2022
@tsmethurst tsmethurst deleted the new-colors branch September 26, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants