Use custom blackfriday renderer to only add mention/hashtag links in normal text #787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #783. blackfriday lets you specify your own renderer, which gives us more control over where we insert the hashtag/mention links. see: https://github.com/russross/blackfriday/blob/v2/html.go#L508
basically,
blackfriday.Text
signals raw text output, andblackfriday.Code
signals code block output, so we can avoid making the conversion there.caveat: posting something like:
doesn't turn #hashtag into a hashtag, but
converts all three, so I think the code that generates the tag list needs some work in the markdown case.