[feature/OFFICIALLY UNSUPPORTED] add nowasm build tag to disable building with WebAssembly #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
changed the title
|
Changed the title to add |
tsmethurst
reviewed
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
nowasmbuild tag that allows building GoToSocial without any WebAssembly modules. This will instead rely on modernc.org/sqlite and locally installed versions of ffmpeg / ffprobe. It prints a warning on server start telling the user not to make any bug reports for media processing issues, and specifically warns them that it may be less secure is it enforces no version checks.THIS IS AN OFFICIALLY UNSUPPORTED BUILD CONFIGURATION.
This probably needs updating with some improved documentation for this, not specifically to tell people about it, but to emphasise specifically how it is unsupported and we are not interested in bug reports produced by the products of these build changes, since we have no idea what their version of ffmpeg / ffprobe could be compiled with support for etc.