Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Account.last_status_at is a date, not datetime #3419

Merged

Conversation

untitaker
Copy link
Contributor

@untitaker untitaker commented Oct 11, 2024

Description

Changes API Account's last_status_at to be a date without time component, for full compat with mastodon.

closes #3418

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@untitaker untitaker marked this pull request as draft October 11, 2024 20:03
@untitaker
Copy link
Contributor Author

untitaker commented Oct 11, 2024

converting to draft until we know all tests pass. only ran internal/typeutils/, the rest is too resource-intensive on local hardware.

golangci-lint run does not pass for me on main branch, but this PR does not add new errors. the link in CONTRIBUTING for the installation instructions is out of date, and I suspect I installed too new a version that comes with additional lints: golangci-lint has version 1.61.0 built with go1.23.1 from a1d6c560 on 2024-09-09T17:44:42Z

@untitaker untitaker force-pushed the acount-laststatusat-date branch from 7e0bb53 to 3d4d8dd Compare October 11, 2024 20:28
@untitaker untitaker marked this pull request as ready for review October 11, 2024 20:28
@tsmethurst
Copy link
Contributor

Thanks! ^_^

@tsmethurst tsmethurst merged commit 95a3162 into superseriousbusiness:main Oct 12, 2024
2 checks passed
@untitaker untitaker deleted the acount-laststatusat-date branch October 12, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] last_status_at returns a date, not a datetime
2 participants