[bugfix] Fix temp table deletion causing runaway allocations #3278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue we've been having with runaway memory allocations causing stress on the garbage collector. For some reason, deleting temporary tables causes SQLite to flip out and keep allocating memory, which is then immediately cleaned up.
This PR fixes the issue by changing the way we delete temporary tables: for Postgres, we can just use
ON COMMIT DROP
, which causes the temp tables to be cleaned up when the transaction ends. For SQLite, we can adjust the max conn lifetime to 5 minutes to ensure that temp tables get closed when the connection is closed + recreated.Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.