[bugfix] Let prometheus client do its own compression handling #3232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update routing to not pass our gzip middleware to prometheus http endpoint, but let it do its own compression handling. Because of this change in this PR, prometheus overwrites the
content-encoding
header toidentity
(ie., no compression) even if our gzip middleware compresses the body, which was confusing http clients (understandably). Rather than fighting prometheus and trying to hack around this by setting another content-encoding later or something, it's easier to just let prometheus win this round and do its own compression.Tested this on the testrig and it fixes the issue.
closes #3216
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.