Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add back exif-terminator and use only for jpeg,png,webp #3161

Conversation

NyaaaWhatsUpDoc
Copy link
Member

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc commented Aug 1, 2024

Description

So it turns out that ffmpeg -map_metadata -1 can indeed clean all metadata, BUT if you're not performing any encoding then the most metadata it can clean is at the global level. Any stream metadata (which is often the case with EXIF) cannot be removed since it's not stepping through the stream data.

This PR adds back exif-terminator to be used exclusively for "jpeg", "png", "webp". All other filetypes fall back to best-effort exif data removal using ffmpeg.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Took the liberty of fixing the test failure :)

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review August 2, 2024 11:34
@NyaaaWhatsUpDoc
Copy link
Member Author

@tsmethurst you're an angel :O

@tsmethurst
Copy link
Contributor

i can be ur angle... or ur deville

@NyaaaWhatsUpDoc
Copy link
Member Author

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 94e8761 into superseriousbusiness:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants