[chore] add back exif-terminator and use only for jpeg,png,webp #3161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So it turns out that
ffmpeg -map_metadata -1
can indeed clean all metadata, BUT if you're not performing any encoding then the most metadata it can clean is at the global level. Any stream metadata (which is often the case with EXIF) cannot be removed since it's not stepping through the stream data.This PR adds back
exif-terminator
to be used exclusively for "jpeg", "png", "webp". All other filetypes fall back to best-effort exif data removal using ffmpeg.Checklist
go fmt ./...
andgolangci-lint run
.