Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no rows in result set error in emoji list command #3152

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix no rows in result set error in emoji list command #3152

merged 1 commit into from
Jul 30, 2024

Conversation

rdelaage
Copy link
Contributor

@rdelaage rdelaage commented Jul 29, 2024 •
edited
Loading

Description

closes #3151

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@rdelaage rdelaage force-pushed the fix/no_rows_emojis branch from 6bc62f2 to 3d42f89 Compare July 29, 2024 18:40
@rdelaage rdelaage force-pushed the fix/no_rows_emojis branch from 3d42f89 to 8ec8968 Compare July 30, 2024 15:45
@NyaaaWhatsUpDoc
Copy link
Member

this is great, thank you @rdelaage :)

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 26022c2 into superseriousbusiness:main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] SQL no row error on emoji list command
2 participants
@rdelaage @NyaaaWhatsUpDoc