Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize empty conversation account list as empty list, not null #3137

Conversation

VyrCossont
Copy link
Contributor

@VyrCossont VyrCossont commented Jul 24, 2024

Description

This pull request fixes a type error when serializing a conversation's account list. This is only about the millionth time I've run into this problem; golang/go#63397 when?

Followup to #3013

Impact

Only affects DMs to yourself and clients that are strict about types. Semaphore and Phanpy apparently don't care.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Ah thanks for fixing this, I just ran into it myself :)

@tsmethurst tsmethurst merged commit db0a471 into superseriousbusiness:main Jul 24, 2024
2 checks passed
@VyrCossont VyrCossont deleted the conversations-null-accounts-fix branch July 24, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants