Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update go-ffmpreg to v0.2.3 #3120

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Updates go-ffmpreg: https://codeberg.org/gruf/go-ffmpreg/releases/tag/v0.2.3

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Nice one :) Any interesting changes to know about?

@NyaaaWhatsUpDoc
Copy link
Member Author

no changes to ffmpeg at all, just the underlying build tools were updated. i had a look at their change logs and couldn't see anything particularly exciting. though the build now seems to have stripped some further unused functions, which mean the odd function tempnam was no longer required to be defined and exported in the WASM runtime which is nice :)

@NyaaaWhatsUpDoc
Copy link
Member Author

also a whopping 200KB in binary size reduction 👩‍🍳 👌

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 409b398 into superseriousbusiness:main Jul 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants